Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In otelcol.auth.headers, clarify usage of from_context #6373

Merged
merged 2 commits into from
Feb 16, 2024
Merged

In otelcol.auth.headers, clarify usage of from_context #6373

merged 2 commits into from
Feb 16, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Feb 15, 2024

I removed an obsolete warning in #5405, but this PR makes it more clear what the impact of other components on the from_context feature is. I also published a similar PR upstream to the Collector docs.

@ptodev ptodev mentioned this pull request Feb 15, 2024
Merged
clayton-cornell
clayton-cornell reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of doc tweaks

docs/sources/flow/reference/components/otelcol.auth.headers.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/otelcol.auth.headers.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 15, 2024
@ptodev @clayton-cornell
Apply suggestions from code review
5293554 
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
clayton-cornell approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptodev ptodev merged commit e7b95cf into main Feb 16, 2024
10 checks passed
@ptodev ptodev deleted the ptodev/header-setter-batch branch February 16, 2024 15:20
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@ptodev @clayton-cornell @BarunKGP
In otelcol.auth.headers, clarify usage of from_context (grafana#6373
32bb13e 
)

* Clarify usage of from_context

* Apply suggestions from code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptodev @clayton-cornell