Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring hostNetwork for integrations #6632

Closed
wants to merge 1 commit into from
Closed

Allow configuring hostNetwork for integrations #6632

wants to merge 1 commit into from

Conversation

iarlyy
Copy link

@iarlyy iarlyy commented Mar 7, 2024

PR Description

This PR implements the ability of setting hostNetwork pod attribute for integration pods. This may be required for example by node_exporter pods, that need to access /proc/sys/net for gathering host level network metrics.

Which issue(s) this PR fixes

Fixes grafana/alloy#250

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

iarlyy
iarlyy commented Mar 17, 2024
View reviewed changes
internal/static/operator/resources_integrations.go
@@ -231,6 +233,11 @@ func mergePodTemplateOptions(inputs ...*podTemplateOptions) podTemplateOptions {
res.ExtraEnvVars = append(res.ExtraEnvVars, ev)
varNames[ev.Name] = struct{}{}
}

if input.HostNetwork {
Copy link
Author

@iarlyy iarlyy Mar 17, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not quite sure that this actually will fit here, any advice is welcome.

though my local testing worked nicely :)

@iarlyy iarlyy marked this pull request as ready for review March 17, 2024 15:47
@clayton-cornell clayton-cornell requested a review from a team March 18, 2024 06:30
@rfratto rfratto added variant/operator Related to Grafana Agent Static Operator. enhancement New feature or request labels Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 11, 2024
@iarlyy iarlyy closed this by deleting the head repository May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention. variant/operator Related to Grafana Agent Static Operator.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node exporter integration can't access /proc/sys/net
3 participants
@iarlyy @CLAassistant @rfratto