feat(converter/otelcol): support converting sigv4authextension
#6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdata` Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…authextension` Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
changed the title
sigv4authextension
rfratto
reviewed
Mar 18, 2024
internal/converter/internal/otelcolconvert/testdata/otelcol_without_validation/sigv4auth.river
Outdated
Show resolved
Hide resolved
…nd not the top-level folder Signed-off-by: hainenber <dotronghai96@gmail.com>
…er result Signed-off-by: hainenber <dotronghai96@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Closes #6442
Notes to the Reviewer
I'm not sure this is the correct approach as the newly added
ConvertWithoutValidationdoesn't really reflect production usage and only for testing. I might open a new PR on the upstream to see if OtelCol folks are OK with opening the struct and/or add a setter to inject mock SigV4 credential provider.PR Checklist