feat(exporter/otelcol): support converting vcenterreceiver
#6714
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
changed the title
vcenterreceivervcenterreceiver
| Endpoint: cfg.Endpoint, | ||
| Username: cfg.Username, | ||
| Password: rivertypes.Secret(cfg.Password), | ||
|
|
There was a problem hiding this comment.
It looks like we are missing the conversion of MetricsBuilderConfig here.
There was a problem hiding this comment.
I've added the converter but it looks like the defaults for agent's vcenter doesn't seem to be in sync with upstream, hence the full-blown River converted result.
These blocks with enabled = true should be omitted, right? Just wanna make sure that I understand the concept of upstream syncing correctly here
There was a problem hiding this comment.
Good catch - I researched it and it made sense to commit the change I tested. The way nested structs were being handled in the component led to this weird behavior and it should be all set now. There is a slight divergence in defaults but it is not so bad anymore.
internal/converter/internal/otelcolconvert/converter_vcenterreceiver.go
Outdated
Show resolved
Hide resolved
…bute + use helper for converting TLS setting Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
force-pushed
the
support-convert-otelcol-vcenterreceiver
branch
from
175f964
to
007998d
Compare
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
|
I disabled automerge so this doesn't cause conflict with a bug fix we are working on. Once that is shipped I can merge it into this PR and get this merged. |
github-actions
bot
added
the
frozen-due-to-age
PR Description
Which issue(s) this PR fixes
Close #6459
Notes to the Reviewer
PR Checklist