Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypher suite support #6755

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

clayton-cornell
Copy link
Contributor

@clayton-cornell clayton-cornell commented Mar 22, 2024

PR Description

Recently, some cipher suites were deprecated in Go 1.22, per golang/go#63413. As a result, certain cipher suites are no longer allowed in recent version of Grafana Agent (0.40.2), including these two:

  • TLS_RSA_WITH_AES_256_GCM_SHA384
  • TLS_RSA_WITH_AES_128_GCM_SHA256

This PR updates the table to show "no" for these two cipher suites.

Which issue(s) this PR fixes

Fixes #9622

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@clayton-cornell clayton-cornell merged commit 89e10ff into main Mar 22, 2024
14 checks passed
@clayton-cornell clayton-cornell deleted the docs/update-cypher-suites branch March 22, 2024 17:05
grafanabot pushed a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit 89e10ff)
grafanabot pushed a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit 89e10ff)
grafanabot pushed a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit 89e10ff)
clayton-cornell added a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit 89e10ff)

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit 89e10ff)

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit 89e10ff)

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.38 backport release-v0.39 backport release-v0.40 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants