Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

add alertmanager alerts/group alerts routes #5

Merged
merged 9 commits into from
Feb 19, 2021

Conversation

domasx2
Copy link
Collaborator

@domasx2 domasx2 commented Feb 18, 2021

adds endpoints to get alertmanager grouped & ungrouped alerts. basically v2/alerts and /v2/alerts/groups from alertmanager api

@owen-d
Copy link
Member

owen-d commented Feb 18, 2021

I don't think we should include the v2 API as cortex/loki don't currently implement them. We can use the /v1/{rules,alerts} instead in the meantime, yes?

@domasx2
Copy link
Collaborator Author

domasx2 commented Feb 18, 2021

I don't think we should include the v2 API as cortex/loki don't currently implement them. We can use the /v1/{rules,alerts} instead in the meantime, yes?

These are alertmanager endpoints, whilst /v1/{rules,alerts} are prometheus endpoints. I think we need the ones in this PR to achieve feature parity. What we might not need is prometheus /v1/alerts... I'll have a nother think tomorrow about it.

Maybe it would be less confusing to do what cortex does and prefix with prom or alertmanager depending on which system the endpoint "belongs" to? And also probably will need to add datasource id to all paths

@domasx2 domasx2 merged commit 734de3c into domas/update-config-route Feb 19, 2021
@owen-d owen-d deleted the domas/am-alerts-routes branch March 4, 2021 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants