Create config tests for each receiver #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
force-pushed
the
yuri-tceretian/receivers-tests
branch
from
59c3848
to
e4c852e
Compare
yuri-tceretian
commented
Feb 9, 2023
gotjosh
approved these changes
Feb 10, 2023
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/grafana/alerting/receivers" | ||
| testing2 "github.com/grafana/alerting/receivers/testing" |
There was a problem hiding this comment.
nit: can this be something a bit more meaningful? e.g. receivers_testing
There was a problem hiding this comment.
yes. I will address it in the follow up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tests for parsing notifier configuration. This increases the coverage of the receiver parsing logic, which opens the possibility for further safe refactorings.
Note: this does not touch any existing tests, which will be refactored in the following PR.