Refactor notifier tests to use Config struct instead json #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
force-pushed
the
yuri-tceretian/refactor-notify-tests
branch
from
adb6e89
to
73027ce
Compare
yuri-tceretian
force-pushed
the
yuri-tceretian/refactor-notify-tests
branch
from
73027ce
to
6e53d2d
Compare
gotjosh
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors tests that test notifiers'
Notifymethods to use Config struct instead of raw JSON. The tests that assert parser logic are deleted because they are duplicates of tests introduced in #57The structures that replace raw JSON are equivalent.