docs: clarify DNS lookup in clustering documentation #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--cluster.join-addresses` supports being given a list of IPs or addresses. The documentation mentions these are resolved via DNS, but it doesn't mention what type of records are supported. Based on the [code](https://github.com/grafana/alloy/blob/c3c761b5e52fcfd605a2274c71adc76b020dd315/internal/alloycli/cluster_builder.go#L168-L173), the only type of supported DNS record is SRV.
rfratto
added
backport release/v1.0
backport-to-agent
clayton-cornell
approved these changes
May 22, 2024
clayton-cornell
added
the
type/docs
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
`--cluster.join-addresses` supports being given a list of IPs or addresses. The documentation mentions these are resolved via DNS, but it doesn't mention what type of records are supported. Based on the [code](https://github.com/grafana/alloy/blob/c3c761b5e52fcfd605a2274c71adc76b020dd315/internal/alloycli/cluster_builder.go#L168-L173), the only type of supported DNS record is SRV. (cherry picked from commit abe384e)
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
`--cluster.join-addresses` supports being given a list of IPs or addresses. The documentation mentions these are resolved via DNS, but it doesn't mention what type of records are supported. Based on the [code](https://github.com/grafana/alloy/blob/c3c761b5e52fcfd605a2274c71adc76b020dd315/internal/alloycli/cluster_builder.go#L168-L173), the only type of supported DNS record is SRV. (cherry picked from commit abe384e)
rfratto
added a commit
that referenced
this pull request
May 22, 2024
`--cluster.join-addresses` supports being given a list of IPs or addresses. The documentation mentions these are resolved via DNS, but it doesn't mention what type of records are supported. Based on the [code](https://github.com/grafana/alloy/blob/c3c761b5e52fcfd605a2274c71adc76b020dd315/internal/alloycli/cluster_builder.go#L168-L173), the only type of supported DNS record is SRV. (cherry picked from commit abe384e) Co-authored-by: Robert Fratto <robertfratto@gmail.com>
rfratto
added a commit
that referenced
this pull request
May 22, 2024
`--cluster.join-addresses` supports being given a list of IPs or addresses. The documentation mentions these are resolved via DNS, but it doesn't mention what type of records are supported. Based on the [code](https://github.com/grafana/alloy/blob/c3c761b5e52fcfd605a2274c71adc76b020dd315/internal/alloycli/cluster_builder.go#L168-L173), the only type of supported DNS record is SRV. (cherry picked from commit abe384e) Co-authored-by: Robert Fratto <robertfratto@gmail.com>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--cluster.join-addressessupports being given a list of IPs or addresses. The documentation mentions these are resolved via DNS, but it doesn't mention what type of records are supported.Based on the code, the only type of supported DNS record is SRV.