Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend to common Azure Authentication UI and AzureCredentials format #361

Closed
Tracked by #366
kostrse opened this issue Apr 15, 2022 · 0 comments · Fixed by #529
Closed
Tracked by #366

Update frontend to common Azure Authentication UI and AzureCredentials format #361

kostrse opened this issue Apr 15, 2022 · 0 comments · Fixed by #529

Comments

@kostrse
Copy link
Contributor

kostrse commented Apr 15, 2022

Azure datasources have common design and implementation of configuration UI, common schema of AzureCredentials in JsonData and common implementation of parsers. This facilitates code reuse, easier changes across the board and consistency in user experience.

image

One of the features which are supported by other Azure datasources but not by Azure Data Explorer is Managed Identity (MSI) authentication.

As a precondition for implementation of MSI authentication, the Azure authentication section of configuration UI should be replaced by same implementation from other Azure datasources and credentials schema should be updated to same schema used by other datasources.

Here is the code which could be borrowed from Prometheus datasource.

Directory: /public/app/plugins/datasource/prometheus/configuration

Since ADX has existing credentials format, extra logic should be implemented which would read credentials in old format if credentials in new format were not found, so they would be rewritten in new format when saved.

This requires backend implementation first:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants