Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy client secret for AzureClientSecretCredentials and OBO #23

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

kostrse
Copy link
Collaborator

@kostrse kostrse commented Dec 29, 2022

During migration of credentials to the common format, existing secrets cannot be migrated because they are not accessible from the frontend.
This change allows to use the already stored legacy client secret by datasource backend even after credential was migrated.

This should allow seamless migration of credentials for Azure Data Explorer and Azure Monitor datasources.

Related:

@kostrse kostrse requested a review from a team as a code owner December 29, 2022 22:45
@kostrse kostrse changed the title Support legacy client secret for AzureClientSecretCredentials Support legacy client secret for AzureClientSecretCredentials and OBO Dec 29, 2022
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@kostrse kostrse merged commit 82502c6 into grafana:main Jan 6, 2023
@kostrse kostrse deleted the legacy-client-secret branch January 6, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants