Azure credentials in common format #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andresmgot
reviewed
Sep 21, 2022
There was a problem hiding this comment.
Thanks for this PR Sergey! My main concern here is that I would much rather have this "new" code in the SDK, even if the OBO implementation is not final rather than having so many special cases here. Is there any major blocker for doing that that I'm missing?
andresmgot
reviewed
Nov 21, 2022
There was a problem hiding this comment.
Thanks for the changes @kostrse! Changes mostly looks good to me but I think there are still some bits we can do in the SDK instead.
|
@kostrse can you merge |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADX datasource currently supports Client Secret and On-Behalf-Of authentication types via own credentials format and implementation of authentication logic.
Other Azure datasources share the same credentials format and reuse shared credentials logic from the Grafana Azure SDK. Features like Managed Identity support are shared via common implementation.
This PR attempts to migrate ADX backend to the new common credentials format (#360) to take advantage of Grafana Azure SDK and potentially support Managed Identity (#362).
Changes:
azcredentials.AzureManagedIdentityCredentials(SDK),azcredentials.AzureClientSecretCredentials(SDK),adxcredentials.AzureClientSecretOboCredentials(ADX), all derived from the commonazcredentials.AzureCredentialsin Grafana Azure SDK.DatasourceSettingsdoesn't have fields related to credentials anymore, credentials encapsulated inazcredentials.AzureCredentials.adxcredentials.FromDatasourceDatatries first to parse credentials in the new common format and fallbacks to the legacy format.This PR doesn't update UI so end user experience doesn't change yet. UI changes will be done separately (#361).
Fixes #360
Related to #362