Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3: When adding a filter/aggregate/groupby: keyboard focus should be on first select #486

Closed
2 tasks done
yaelleC opened this issue Oct 10, 2022 · 3 comments
Closed
2 tasks done

Comments

@yaelleC
Copy link
Contributor

yaelleC commented Oct 10, 2022

When using the keyboard the create an ADX query, and hitting the + button to create a filter/agregate/group by item, the focus is lost.
It would be nice to have focus on the first element of the newly created form instead.

We have set up this issue as lowest a11y prio as it requires quite a lot of effort

Screen.Recording.2022-10-10.at.10.42.13.mov

To Do

  • Get UX input to confirm the wanted behaviour for the form
  • Implement the changes
@andresmgot
Copy link
Contributor

does this happens with the new editor? (this editor will go away)

@asimpson asimpson self-assigned this Oct 24, 2022
@asimpson
Copy link
Contributor

@andresmgot Yep, it also happens on the new Editor.

@diegoadams or @catherineymgui any thoughts from a UX perspective here?

@catherineymgui
Copy link

Yeah, I agree that there should be focus on the first element once a new filter is created.

asimpson added a commit that referenced this issue Jan 18, 2023
Requires a new version of the experimental package to work.

Ref #486
asimpson added a commit that referenced this issue Jan 19, 2023
- Fixes various eslint issues

Ref #486
asimpson added a commit that referenced this issue Jan 19, 2023
- Fixes various eslint issues
- Updates grafana/experimental version

Ref #486
asimpson added a commit that referenced this issue Jan 19, 2023
* Puts focus on field when a new field is added.

- Fixes various eslint issues
- Updates grafana/experimental version

Ref #486

* fix label width

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants