Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puts focus on field when a new field is added. #543

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Puts focus on field when a new field is added. #543

merged 3 commits into from
Jan 19, 2023

Conversation

asimpson
Copy link
Contributor

Peek 2023-01-19 10-08

To test

  1. Load up ADX
  2. Select the correct database
  3. Navigate from that dropdown to the Builder via TAB on your keyboard.
  4. You should be able to add filter groups and and other clauses via TAB and Enter or Space. The focus should move to the logically correct place after taking an action.

Other changes

  • Fixes various eslint issues. We might want to revisit how @grafana/experimental defines Children to avoid the Fragment usage here?
  • I also could see a desire to separate "ui" properties from data properties in our types, e.g. focus being added to QueryEditorReduceExpressionArray.
  • Updates grafana/experimental version

Ref #486

@asimpson
Puts focus on field when a new field is added.
ada6adc 
- Fixes various eslint issues
- Updates grafana/experimental version

Ref #486
@asimpson asimpson requested a review from a team as a code owner January 19, 2023 15:17
@asimpson
Copy link
Contributor Author

fixing tests...

@github-actions
Copy link

Backend code coverage report for PR #543
No changes

@github-actions
Copy link

Frontend code coverage report for PR #543

Plugin Main PR Difference
src 81.89% 81.89% 0%

aangelisc
aangelisc approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

alyssabull
alyssabull approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@alyssabull alyssabull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asimpson asimpson merged commit 80c646f into main Jan 19, 2023
@asimpson asimpson deleted the simpson-fix-focus branch January 19, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@alyssabull alyssabull alyssabull approved these changes

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asimpson @aangelisc @alyssabull