Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache mutex2 #273

Merged
merged 3 commits into from
May 2, 2018
Merged

Cache mutex2 #273

merged 3 commits into from
May 2, 2018

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented May 2, 2018

No description provided.

DanCech and others added 3 commits May 2, 2018 11:47
* no need to point to reCacheMutex, since we work on the Aggregator via
  a pointer it is never copied so we operate on the same, correct mutex value
* set Aggregator and snapshot fields with keys, so that:
  - things are more explicit/clear,
  - we can skip unneeded fields
* set optional fields after struct construction, so we don't need to
  predeclare temporary values.
* rely on zero value for mutex and WaitGroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants