Deploy new packages when tag is added #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaliao
force-pushed
the
fl/tag-trigger-package
branch
from
512bf5a
to
25f9f31
Compare
fionaliao
changed the title
jesusvazquez
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you merge a new release into master and then add a new tag, the publish_release workflow fails (example). This is because packages aren't being deployed when a new tag is added. This PR adds the build/package/deploy steps to the publish_release workflow so correct packages are being deployed before the publish step.
Also fixed an issue with packaging - after #479 the package step started failing because it was trying to build a binary before packaging it. The fix here was to make sure both the arm64/amd64 binaries are being created in the build step so the package step doesn't try to build a new binary.