Add arm64 architecture to goreleaser #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaliao
commented
Feb 21, 2023
| @@ -171,4 +171,4 @@ jobs: | |||
| - checkout | |||
| - run: curl -sfL https://goreleaser.com/static/run | bash | |||
| # For dry runs use the following and comment the above | |||
| # - run: curl -sfL https://goreleaser.com/static/run | bash -s -- --rm-dist --skip-publish --snapshot | |||
There was a problem hiding this comment.
Was getting a warning Flag --rm-dist has been deprecated, please use --clean instead
fionaliao
commented
Feb 21, 2023
Comment on lines
-15
to
-20
| - replacements: | ||
| darwin: Darwin | ||
| linux: Linux | ||
| windows: Windows | ||
| 386: i386 | ||
| amd64: x86_64 |
There was a problem hiding this comment.
Was getting a warning DEPRECATED: archives.replacements should not be used anymore, check https://goreleaser.com/deprecations#archivesreplacements for more info, so updated to use name_template instead
leizor
approved these changes
Feb 21, 2023
|
💪 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by #506 (review)
Tested here: https://app.circleci.com/pipelines/github/grafana/carbon-relay-ng/314/workflows/c8068722-1e83-4cab-83d1-6e5aea53b09c/jobs/2863
Also updated a couple of goreleaser settings that were deprecated