Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse queryTimeout when either string or number #456

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Parse queryTimeout when either string or number #456

merged 5 commits into from
Jul 19, 2023

Conversation

aangelisc
Copy link
Contributor

Fixes #440

@aangelisc aangelisc self-assigned this Jul 18, 2023
@aangelisc aangelisc requested a review from a team as a code owner July 18, 2023 12:20
asimpson
asimpson previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit aside, looks good to me 🏆

pkg/plugin/driver_test.go Outdated Show resolved Hide resolved
@aangelisc aangelisc requested a review from asimpson July 19, 2023 08:14
adamyeats
adamyeats approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@adamyeats adamyeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@aangelisc aangelisc merged commit b5758d7 into main Jul 19, 2023
8 of 11 checks passed
@aangelisc aangelisc deleted the andreas/fix-timeout-parsing branch July 19, 2023 12:57
alyssabull pushed a commit that referenced this pull request Aug 10, 2023
@aangelisc @alyssabull
Parse queryTimeout when either string or number (#456)
be2a093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamyeats adamyeats adamyeats approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@asimpson asimpson Awaiting requested review from asimpson

Assignees

@aangelisc aangelisc

Labels
effort/small
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception is thrown when configuring Query Timeout
3 participants
@aangelisc @asimpson @adamyeats