Add support LogpullReceived and LogpullFields #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also include support for gzip content encoding while reading response. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
This PR also include support for gzip content encoding while reading response. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
…go into logpull-received Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a copy of the initial PR to the upstream cloudflare#743.
This fork in grafana organization was created to move from a personal fork github.com/cyriltovena/cloudflare-go in loki to grafana fork.
Initial PR to the upstream is not going to be merged, because it was discussed that grafana will move to the Logpush and doesn't need these changes upstream cloudflare#743 (comment)
Moving to Logpush is not happening soon, that's why I think it is a good idea to move to grafana fork as the main dependency and remove replace statement from Loki go.mod
https://github.com/grafana/loki/blob/b3e038c7a8c72ee72aaad201efd17af3ec4ba9e7/go.mod#L321
Moving to the fork as the main dependency will allow removing that replace statement from packages that use Loki as a dependency: grafana/agent and open-telemetry/opentelemetry-collector-contrib