Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new alertmanager flags. #275

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pstibrany
Copy link
Member

This PR updates alertmanager storage flags.

@pstibrany pstibrany requested a review from a team as a code owner March 17, 2021 09:07
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a question)

},
s3: {
'alertmanager.storage.s3.url': 'https://%s/%s' % [$._config.aws_region, $._config.alertmanager_s3_bucket_name],
'alertmanager-storage.s3.region': $._config.aws_region,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work without endpoint? I don't remember. Please double check it in Cortex.

@pstibrany pstibrany marked this pull request as draft March 17, 2021 09:35
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants