Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed alertmanager config to use the new storage config #308

Merged
merged 1 commit into from
May 17, 2021

Conversation

pracucci
Copy link
Collaborator

What this PR does:
Similarly to #306, in this PR I'm switching the ruler to use the new storage config. I'm also taking the opportunity to do a couple of other changes:

  1. Remove configdb support from ruler and alertmanager: wasn't working even before, so I guess none was using it
  2. Do not auto-configure alertmanager_s3_bucket_name and ruler_s3_bucket_name (like we already do for GCS)

Which issue(s) this PR fixes:
N/A

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner May 17, 2021 10:44
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pracucci pracucci merged commit 51b880a into main May 17, 2021
@pracucci pracucci deleted the migrate-alertmanager-config-to-new-storage branch May 17, 2021 11:32
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…ertmanager-config-to-new-storage

Changed alertmanager config to use the new storage config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants