Fixed and improved runtime config alerts and playbooks #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
playbooks-for-config-alerts
branch
from
ae827c2
to
e0c8194
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…for-config-alerts Fixed and improved runtime config alerts and playbooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I'm addressing the 2 alerts on runtime config:
CortexInconsistentRuntimeConfig: the metric name was wrong, so the alert wasn't workingCortexInconsistentConfigalert toCortexInconsistentRuntimeConfigand increased severity tocriticalCortexBadRuntimeConfigalert severity tocriticaland removed support forcortex_overrides_last_reload_successfulmetric (was removed in Cortex 1.3.0)Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]