Add playbook for CortexRequestErrors and config option to exclude specific routes #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cific routes Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Jun 23, 2021
| @@ -355,10 +366,6 @@ WAL corruptions are only detected at startups, so at this point the WAL/Checkpoi | |||
| 2. Equal or more than the quorum number but less than replication factor: There is a good chance that there is no data loss if it was replicated to desired number of ingesters. But it's good to check once for data loss. | |||
| 3. Equal or more than the replication factor: Then there is definitely some data loss. | |||
|
|
|||
| ### CortexRequestErrors | |||
pstibrany
reviewed
Jun 23, 2021
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ | |||
| * [ENHANCEMENT] cortex-mixin: Make `cluster_namespace_deployment:kube_pod_container_resource_requests_{cpu_cores,memory_bytes}:sum` backwards compatible with `kube-state-metrics` v2.0.0. #317 | |||
| * [ENHANCEMENT] Added documentation text panels and descriptions to reads and writes dashboards. #324 | |||
| * [ENHANCEMENT] Dashboards: defined container functions for common resources panels: containerDiskWritesPanel, containerDiskReadsPanel, containerDiskSpaceUtilization. #331 | |||
| * [ENHANCEMENT] cortex-mixin: Added `alert_excluded_routes` config to exclude specific routes from alerts. #326 | |||
Signed-off-by: Marco Pracucci <marco@pracucci.com>
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…or-request-errors Add playbook for CortexRequestErrors and config option to exclude specific routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I've added a config option to exclude specific routes from
CortexRequestErrorsandCortexRequestLatencyerrors. I've also added a playbook forCortexRequestErrors. The alert is very generic and could trigger because of many reasons: any suggestion on which common use cases we should cover?Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]