Improved alert messages with Cortex cluster #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Jul 2, 2021
No. If you enable the string interpolation in jsonnet then you have to escape |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…t-messages-based-on-group-labels Improved alert messages with Cortex cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We're not using a consistent way to reference a Cortex cluster in alert messages. Sometimes we use the
joblabel, sometimes thenamespaceother times we don't reference it at all. However, the mixin supports to configure the labels used to "group metrics by cluster" viacluster_labels(or the deprecatedalert_aggregation_labels).In this PR I'm defining
alert_aggregation_variables(based oncluster_labels/alert_aggregation_labels) containing the Prometheus templating variables for the labels used to group by cluster and use it in alert messages. For example, the diff for an alert is:I've checked the whole diff in our infra and should be good.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]