Aded object storage metrics for Ruler and Alertmanager #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gotjosh
reviewed
Jul 6, 2021
| @@ -83,5 +83,8 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| $.panel('Latency') + | |||
| utils.latencyRecordingRulePanel('cortex_request_duration_seconds', $.jobSelector($._config.job_names.gateway) + [utils.selector.re('route', 'api_v1_alerts|alertmanager')]) | |||
| ) | |||
| ) | |||
| .addRows( | |||
| $.getObjectStoreRows('Alertmanager Configuration Object Store (Alertmanager accesses)', 'alertmanager-storage') | |||
There was a problem hiding this comment.
out of curiosity, what's the second argument of this function?
There was a problem hiding this comment.
The "component" exposing the metrics, which is the name of the internal component using the object store client (used to differentiate all clients when running in single binary mode).
pracucci
deleted the
add-object-storage-metrics-to-ruler-and-alertmanager-dashboards
branch
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…-storage-metrics-to-ruler-and-alertmanager-dashboards Aded object storage metrics for Ruler and Alertmanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The Ruler and Alertmanager keeps the config in the object storage, but we don't show the object storage metrics in the Ruler and Alertmanager dashboard. This PR fixes it.
Example:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]