Reduce ingester gRPC max concurrent streams to 10,000 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limit governs the number of server calls that gRPC will run in parallel. Beyond this limit, requests will queue in the caller. While parallelism helps to improve throughput, it is unrealistic that 100,000 operations would be able to proceed at once, considering typical CPU core counts, locking, etc. Even 10,000 is probably too high, but changing the limit by more than one order of magnitude also seemed rash. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
aknuds1
approved these changes
Jul 7, 2021
|
Don't merge yet - want to try it out first. |
bboreham
changed the title
|
This change was incorporated in #369. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Reduce the limit which governs the number of server calls that gRPC will run in parallel. Beyond this limit, requests will queue in the caller.
While parallelism helps to improve throughput, it is unrealistic that 100,000 operations would be able to proceed at once, considering typical CPU core counts, locking, etc.
Even 10,000 is probably too high, but changing the limit by more than one order of magnitude also seemed rash.
Checklist
CHANGELOG.mdupdated