Add new alerts for alertmanager sharding mode of operation. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesg
force-pushed
the
alertmanager-sharding-alerts
branch
from
425e936
to
0e78e94
Compare
|
Question: Shall we to add the playbooks onto this PR or open a new PR for them? |
gotjosh
approved these changes
Aug 24, 2021
gotjosh
reviewed
Aug 24, 2021
pracucci
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Good job! All the alerts make sense to me 👍
I think it's a better practice to write the playbook along with the alert instead of postponing it. You can start very easy, explaining (1) when the alert fires and (2) how to investigate (see other playbooks as an example). The "how to investigate" could even just "check out the logs to find the specific error occurred", but at least with (1) we explain when the alert fires and how the system works.
1 task
stevesg
force-pushed
the
alertmanager-sharding-alerts
branch
from
8c94ddc
to
6422e0b
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…er-sharding-alerts Add new alerts for alertmanager sharding mode of operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds new alerts to cover aspects of the alertmanager pertinent to sharding operation.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]