Fixes to initial state sync panels on alertmanager dashboard. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Change minimal interval to 1m for sync duration and fetch state panels.
This is in order to show infrequent events at smaller time windows.
2) Change syncs/sec panel to reflect absolute value of metric not rate.
The initial sync only occurs once per-tenant so the counter value is
essentially 0 or 1. Due to how per-tenant metrics are aggregated, the
external facing metric really acts more like a gauge reflecting the number
of tenants which achieved each outcome.
Also, stack this panel as it becomes easier to visually see when the initial
syncs have completed for all tenants (e.g. during a rollout).
stevesg
force-pushed
the
am-dash-tweaks
branch
from
8f0c4bb
to
795b0ba
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…eaks Fixes to initial state sync panels on alertmanager dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Change minimal interval to 1m for sync duration and fetch state panels.
This is in order to show infrequent events at smaller time windows.
Change syncs/sec panel to reflect absolute value of metric not rate.
The initial sync only occurs once per-tenant so the counter value is
essentially 0 or 1. Due to how per-tenant metrics are aggregated, the
external facing metric really acts more like a gauge reflecting the number
of tenants which achieved each outcome.
Also, stack this panel as it becomes easier to visually see when the initial
syncs have completed for all tenants (e.g. during a rollout).
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]