Add recording rules for Alertmanager dashboard, #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesg
force-pushed
the
am-notifications-rules
branch
from
af439cf
to
8ef58d4
Compare
stevesg
force-pushed
the
am-notifications-rules
branch
2 times, most recently
from
c33b542
to
5cb38bc
Compare
stevesg
changed the title
gotjosh
approved these changes
Sep 8, 2021
| @@ -11,11 +11,11 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| }) | |||
| .addPanel( | |||
| $.panel('Total Alerts') + | |||
| $.statPanel('sum(cortex_alertmanager_alerts{%s})' % $.jobMatcher('alertmanager'), format='short') | |||
| $.statPanel('sum(cluster_job_%s:cortex_alertmanager_alerts:sum{%s})' % [$._config.per_instance_label, $.jobMatcher('alertmanager')], format='short') | |||
There was a problem hiding this comment.
If the recording rule is a sum, do we need to sum here again?
There was a problem hiding this comment.
Good question, I also wondered about this, but in general I decided to leave all the sum()s as-is because the dashboard allows selecting multiple cluster/namespaces.
With large numbers of tenants the queries for some panels on thos dashboard can become quite slow as the metrics exposed are per-tenant.
stevesg
force-pushed
the
am-notifications-rules
branch
from
cd4fb65
to
826af4d
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…ations-rules Add recording rules for Alertmanager dashboard,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
With large numbers of tenants the queries for these panels can become quite
slow as the metrics exposed are per-tenant.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]