Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alertmanager: Add sharding configuration. #394

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Alertmanager: Add sharding configuration. #394

merged 2 commits into from
Sep 16, 2021

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented Sep 15, 2021 •
edited

What this PR does:
Adds configuration for using the sharding feature of Alertmanager.

The following differences apply when using sharding:

  • Ring configuration must be provided (consul is the default)
  • Arguments --alertmanager.cluster.listen-address and --alertmanager.cluster.peers are not needed
  • Service ports gossip-udp gossip-tcp are not needed

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@stevesg stevesg marked this pull request as ready for review September 15, 2021 11:42
@stevesg stevesg requested a review from a team as a code owner September 15, 2021 11:42
gotjosh
gotjosh approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but feels unfair to review this - maybe @pracucci can share more light?

aknuds1
aknuds1 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevesg stevesg merged commit e708d94 into grafana:main Sep 16, 2021
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
@stevesg
Merge pull request grafana/cortex-jsonnet#394 from stevesg/josh-alert…
f1edc62 
…manager

Alertmanager: Add sharding configuration.
@pracucci pracucci mentioned this pull request Jun 24, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotjosh gotjosh gotjosh approved these changes

@aknuds1 aknuds1 aknuds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevesg @gotjosh @aknuds1