Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed chunks storage query sharding config support #398

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

pracucci
Copy link
Collaborator

What this PR does:
Chunks storage query sharding never hit production. To remove some misunderstanding, I would suggest to remove its support from this mixin config.

Which issue(s) this PR fixes:
N/A

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner September 20, 2021 12:44
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 41a44af into main Sep 20, 2021
@pracucci pracucci deleted the remove-chunks-storage-query-sharding branch September 20, 2021 14:38
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…nks-storage-query-sharding

Removed chunks storage query sharding config support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants