Add CortexRolloutStuck alert #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
simonswine
approved these changes
Oct 13, 2021
Comment on lines
+421
to
+426
| ( | ||
| max without (revision) ( | ||
| kube_statefulset_status_current_revision | ||
| unless | ||
| kube_statefulset_status_update_revision | ||
| ) |
There was a problem hiding this comment.
I am not too sure why stateful sets need that revision check, but I guess it's also upstream: https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/6c72589035f4f49674a56cf97a3ec1a02f14671a/alerts/apps_alerts.libsonnet#L128
So it should be ok 🙂
There was a problem hiding this comment.
Yeah, I learned it from there.
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…tuck-rollout Add CortexRolloutStuck alert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I propose to add the
CortexRolloutStuckwhich fires if a Cortex StatefulSet or Deployment rollout is stuck. I've manually tried the queries and they should work as expected. The alert is a warning to get some confidence with it, but final goal would be to run it as critical.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]