add ability to override datasource for dashboards #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pracucci, would you mind if we got your eyes on this please? |
pracucci
approved these changes
Oct 20, 2021
3 tasks
jmcarp
added a commit
to jmcarp/mimir
that referenced
this pull request
Apr 25, 2022
Adapted from grafana/cortex-jsonnet#407. Signed-off-by: Josh Carp <jm.carp@gmail.com>
pstibrany
pushed a commit
to grafana/mimir
that referenced
this pull request
Apr 25, 2022
Adapted from grafana/cortex-jsonnet#407. Signed-off-by: Josh Carp <jm.carp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the ability to override the datasource used for dashboards via the _config.dashboard_datasource object.
We currently generate and import these dashboards as provisioned dashboards in Grafana and are unable to override the default datasource in the UI. The other alternative we have is to run a
jqedit on top of the generated dashboards, but that's not ideal.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]