Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use alertmanager jobname for alertmanager dashboard panels #411

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

aallawala
Copy link
Contributor

@aallawala aallawala commented Oct 18, 2021

What this PR does:
This PR adjusts the alertmanager dashboard to use the _config.job_names.alertmanager instead of the hardcoded 'alertmanager' value.
Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment about the default value. A part from this, LGTM. Thanks

cortex-mixin/config.libsonnet Outdated Show resolved Hide resolved
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci merged commit b8901a9 into grafana:main Oct 22, 2021
@aallawala aallawala deleted the aja_alertmanager branch November 2, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants