Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb: Add multi concurrency and max idle connections store gateway params #414

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Nov 2, 2021

What this PR does:
Add multi concurrency and max idle connections store gateway params.

Which issue(s) this PR fixes:

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1 aknuds1 force-pushed the chore/tsdb-add-multi-concurrency branch from b060a16 to 34b2fad Compare November 2, 2021 09:04
@aknuds1 aknuds1 marked this pull request as ready for review November 2, 2021 09:05
@aknuds1 aknuds1 requested a review from a team as a code owner November 2, 2021 09:05
cortex/tsdb.libsonnet Outdated Show resolved Hide resolved
aknuds1 and others added 3 commits November 2, 2021 10:38
…rams

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 force-pushed the chore/tsdb-add-multi-concurrency branch from 874d81e to e751ecc Compare November 2, 2021 09:39
@aknuds1 aknuds1 requested a review from pracucci November 2, 2021 09:39
@aknuds1 aknuds1 added the enhancement New feature or request label Nov 2, 2021
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a nit)

cortex/tsdb.libsonnet Outdated Show resolved Hide resolved
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 force-pushed the chore/tsdb-add-multi-concurrency branch from e3956bd to 92d7684 Compare November 2, 2021 13:34
@aknuds1 aknuds1 merged commit f723ef3 into main Nov 2, 2021
@aknuds1 aknuds1 deleted the chore/tsdb-add-multi-concurrency branch November 2, 2021 13:34
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…-add-multi-concurrency

tsdb: Add multi concurrency and max idle connections store gateway params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants