cortex: Define Azure object storage ruler args #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
changed the title
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/azure-ruler
branch
from
4f8c745
to
64fa11d
Compare
pracucci
reviewed
Nov 10, 2021
cortex/config.libsonnet
Outdated
Comment on lines
262
to
264
| 'ruler-storage.azure.container-name': '%(cluster)s-%(namespace)s-ruler' % $._config, | ||
| 'ruler-storage.azure.account-name': '$(BLOCKS_STORAGE_AZURE_ACCOUNT_NAME)', | ||
| 'ruler-storage.azure.account-key': '$(BLOCKS_STORAGE_AZURE_ACCOUNT_KEY)', |
There was a problem hiding this comment.
These should all be configurable. Not autogenerated (and what's BLOCKS_STORAGE_AZURE_ACCOUNT_NAME?):
There was a problem hiding this comment.
@pracucci OK, looking into it.
There was a problem hiding this comment.
For my understanding, when you say "should be configurable", do you mean that they should exist as fields in the _config object?
The values BLOCKS_STORAGE_AZURE.* look like Kubernetes environment variables but I'm not sure how they are getting to the Pod spec. Is there something special in Azure or is this tbd?
There was a problem hiding this comment.
I've pushed a revision parameterizing the fields instead.
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/azure-ruler
branch
from
b456511
to
afb7bc8
Compare
jdbaldry
reviewed
Nov 10, 2021
jdbaldry
approved these changes
Nov 10, 2021
|
I've tested the latest revision FWIW, and it looks good. |
pracucci
approved these changes
Nov 15, 2021
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…e-ruler cortex: Define Azure object storage ruler args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Define ruler object storage arguments for Azure.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]