Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_selectors and sum_by for latency recording rule panel #429

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jiachengxu
Copy link

@jiachengxu jiachengxu commented Feb 14, 2022

Signed-off-by: Jiacheng Xu jiachengxu@users.noreply.github.com

What this PR does:
This PR adds two options to pass the extra_selectors and sum_by to the latencyRecordingRulePanel function.
This is really useful when Prometheus adds external labels (cluster labels) before sending the recording metrics to Cortex

Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Jiacheng Xu <jiachengxu@users.noreply.github.com>
@jiachengxu jiachengxu requested a review from a team as a code owner February 14, 2022 10:13
Signed-off-by: Jiacheng Xu <jiachengxu@users.noreply.github.com>
Signed-off-by: Jiacheng Xu <jiachengxu@users.noreply.github.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants