Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more granular loadgen histograms #152

Merged
merged 3 commits into from Mar 4, 2021
Merged

feat: more granular loadgen histograms #152

merged 3 commits into from Mar 4, 2021

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Mar 4, 2021

  • Add 15 seconds as a bucket interval for loadgen metrics
  • Add loadgen as namespace for loadgen metrics

@jtlisi
feat: more granular loadgen histograms
3516146 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@jtlisi jtlisi requested a review from a team as a code owner March 4, 2021 16:12
@jtlisi
chore: update changelog
dfd7350 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@jtlisi
fix changelog
10396d5 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
56quarters
56quarters approved these changes Mar 4, 2021
View reviewed changes
Copy link

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtlisi jtlisi merged commit a878e45 into main Mar 4, 2021
@jtlisi jtlisi deleted the 20210304_improve_loadgen branch March 4, 2021 16:23
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 7, 2022
@jtlisi
feat: more granular loadgen histograms (grafana/cortex-tools#152)
727cecf 
* feat: more granular loadgen histograms

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>

* chore: update changelog

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>

* fix changelog

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@simonswine simonswine mentioned this pull request Jan 7, 2022
Merged
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 12, 2022
@jtlisi
feat: more granular loadgen histograms (grafana/cortex-tools#152)
6bcc223 
* feat: more granular loadgen histograms

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>

* chore: update changelog

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>

* fix changelog

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@56quarters 56quarters 56quarters approved these changes

Assignees
No one assigned
Labels
command/loadgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtlisi @56quarters