feat: more granular loadgen histograms (grafana/cortex-tools#152)

* feat: more granular loadgen histograms Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * chore: update changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
grafana · Mar 4, 2021 · 6bcc223 · 6bcc223
1 parent 823faa6
commit 6bcc223
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/cmd/cortextool/CHANGELOG.md b/cmd/cortextool/CHANGELOG.md
@@ -4,8 +4,12 @@ Order should be `CHANGE`, `FEATURE`, `ENHANCEMENT`, and `BUGFIX`
 
 ## Unreleased
 
+* [CHANGE] Loadgen: Add `loadgen` namespace to loadgen metrics. #152
+  * `write_request_duration_seconds` --> `loadgen_write_request_duration_seconds`
+  * `query_request_duration_seconds` --> `loadgen_query_request_duration_seconds`
 * [ENHANCEMENT] Return detailed HTTP error messages. #146
 * [ENHANCEMENT] Check for duplicate rule records in `cortextool rules check`. #149
+* [ENHANCEMENT] Loadgen: Metrics now use histogram with an additional `15` bucket.
 
 ## v0.7.2
 

diff --git a/cmd/cortextool/pkg/commands/loadgen.go b/cmd/cortextool/pkg/commands/loadgen.go
@@ -26,14 +26,22 @@ import (
 	"gopkg.in/alecthomas/kingpin.v2"
 )
 
+var (
+	// 15 seconds is a common send interval. To provide useful metrics at high latencies we will
+	// add 15 to the default Prometheus buckets
+	defBuckets = append(prometheus.DefBuckets, 15)
+)
+
 var writeRequestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{
-	Name:    "write_request_duration_seconds",
-	Buckets: prometheus.DefBuckets,
+	Namespace: "loadgen",
+	Name:      "write_request_duration_seconds",
+	Buckets:   defBuckets,
 }, []string{"success"})
 
 var queryRequestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{
-	Name:    "query_request_duration_seconds",
-	Buckets: prometheus.DefBuckets,
+	Namespace: "loadgen",
+	Name:      "query_request_duration_seconds",
+	Buckets:   defBuckets,
 }, []string{"success"})
 
 type LoadgenCommand struct {