Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from go-kit/kit/log to the slimmer go-kit/log. #218

Closed
wants to merge 2 commits into from

Conversation

cristiangreco
Copy link
Contributor

@cristiangreco cristiangreco requested a review from a team as a code owner November 3, 2021 19:38
@bboreham
Copy link

bboreham commented Nov 5, 2021

Please can you pin github.com/go-kit/kit to v0.12.0 to avoid inconsistencies between it and github.com/go-kit/log.
See cortexproject/cortex#4544

@cristiangreco
Copy link
Contributor Author

@bboreham have updated the go.mod file and run a go mod tidy, which brings in other updates.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@colega
Copy link
Contributor

colega commented Jul 4, 2022

Hey, @cristiangreco, are you going to work on this or we can close it as stale?

@cristiangreco
Copy link
Contributor Author

Closing this, happy for someone else to push this change forward, if needed.

@cristiangreco cristiangreco deleted the cristian/go-kit branch July 4, 2022 11:45
friedrichg pushed a commit to cortexproject/cortex-tools that referenced this pull request Aug 1, 2023
Signed-off-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants