Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag to set number of workers #30

Merged
merged 3 commits into from
May 3, 2021
Merged

feat: Add flag to set number of workers #30

merged 3 commits into from
May 3, 2021

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented May 1, 2021

When running the github-archive-parser library, my local machine quickly starts to heat up. Similarly, when deploying the corresponding Dockerfile on a DO droplet, I always run into out-of-memory issues.

This PR adds an optional --numWorkers flag to limit the number of workers to spawn.

Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr merged commit 2895bd6 into grafana:master May 3, 2021
@marefr
Copy link
Member

marefr commented May 3, 2021

Thanks for contributing

@amaury1093 amaury1093 deleted the am/num-workers branch May 3, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants