Change default memberlist.stream-timeout from 10s to 2s
#458
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
approved these changes
Jan 8, 2024
We have our own `packet_dial_timeout` and `packet_write_timeout` settings that we use for regular memberlist messages. However, special messages such as push-pull are managed by the memberlist library. A `10s` timeout is too large and causes joins to nonexistent IPs to take a really long time. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/ml-stream-timeout
branch
from
cd8c952
to
db8d167
Compare
4 tasks
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 8, 2024
Update dskit to a150e79e458136446a0c0172aa9467315872bfce. Specifically, this pulls in a change to the default timeout for memberlist and a change to cache client metrics: * grafana/dskit#458 * grafana/dskit#461 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 9, 2024
Update dskit to `a150e79e458136446a0c0172aa9467315872bfce`. Specifically, this pulls in a change to the default timeout for memberlist and a change to cache client metrics: * grafana/dskit#458 * grafana/dskit#461 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We have our own
packet_dial_timeoutandpacket_write_timeoutsettings that we use for regular memberlist messages. However, special messages such as push-pull are managed by the memberlist library. A10stimeout is too large and causes joins to nonexistent IPs to take a really long time.We've been using a
2stimeout on Mimir in production for several weeks at this point with no adverse affects.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]