Remove deprecated metrics emitted by Memcached client #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Redis support was added, cache metrics had "memcached" in their names. Now, we use a backend label to identify which cache is being used. We've been emitting metrics for Memcached with both the old and new names for about 11 months. It's safe to remove them at this point. On Mimir, our dashboards will work with either name so we won't be losing any data. Example of the old name: `thanos_cache_memcached_hits_total`. Example of the new name: `thanos_cache_hits_total`. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
jhalterman
approved these changes
Jan 5, 2024
4 tasks
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 8, 2024
Update dskit to a150e79e458136446a0c0172aa9467315872bfce. Specifically, this pulls in a change to the default timeout for memberlist and a change to cache client metrics: * grafana/dskit#458 * grafana/dskit#461 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 9, 2024
Update dskit to `a150e79e458136446a0c0172aa9467315872bfce`. Specifically, this pulls in a change to the default timeout for memberlist and a change to cache client metrics: * grafana/dskit#458 * grafana/dskit#461 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Before Redis support was added, cache metrics had "memcached" in their names. Now, we use a backend label to identify which cache is being used.
We've been emitting metrics for Memcached with both the old and new names for about 11 months. It's safe to remove them at this point. On Mimir, our dashboards will work with either name so we won't be losing any data.
Example of the old name:
thanos_cache_memcached_hits_total.Example of the new name:
thanos_cache_hits_total.Which issue(s) this PR fixes:
Part of #452
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]