This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Migrate to plugin-sdk #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
reviewed
Oct 4, 2019
go.mod
Outdated
| @@ -11,15 +11,18 @@ replace google.golang.org/genproto => google.golang.org/genproto v0.0.0-20180514 | |||
| go 1.12 | |||
|
|
|||
| require ( | |||
| github.com/apache/arrow/go/arrow v0.0.0-20190716210558-5f564424c71c | |||
| github.com/golang/protobuf v1.2.0 // indirect | |||
| github.com/apache/arrow/go/arrow v0.0.0-20191004105443-1e2cf1f95df0 | |||
There was a problem hiding this comment.
Is latest here going to work with the frontend? Before we were having issues if it wasn't at 0.14.1
There was a problem hiding this comment.
replace github.com/apache/arrow/go/arrow => github.com/apache/arrow/go/arrow v0.0.0-20190716210558-5f564424c71c makes the UI work again for me
There was a problem hiding this comment.
You're right, this is my lack of Go module skills. I'll update it!
|
Fixes #10 |
kylebrandt
approved these changes
Oct 4, 2019
kylebrandt
reviewed
Oct 4, 2019
pkg/gelpoc/service.go
Outdated
| for _, val := range results.Values { | ||
| df := val.AsDataFrame() | ||
| df.RefID = refID | ||
| //df.RefID = refID |
There was a problem hiding this comment.
This is needed for the filteredFrames (hidden) functionality to work.
marcusolsson
force-pushed
the
use-plugin-sdk
branch
from
39fc5fa
to
2a1e8b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.