Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the open time field supposed to show ? #145

Closed
zakuru opened this issue Oct 16, 2021 · 1 comment · Fixed by #164
Closed

What is the open time field supposed to show ? #145

zakuru opened this issue Oct 16, 2021 · 1 comment · Fixed by #164

Comments

@zakuru
Copy link

zakuru commented Oct 16, 2021 •
edited by timlevett

Hi,
Running the dashboard I get 0sec or even negative numbers for the filed open_time
What is it supposed to show ?
image

github-datasource/pkg/github/pull_requests.go

Line 64 in 4e737cc

openTime := data.NewField("open_time", nil, []float64{})

@timlevett
Copy link
Member

I was just coming to ask the same question. I was playing around with this a bit. It seems to only be filled out for OPEN PRs, otherwise 0s. It would be neat if if it was a closed/merged PR it will filled in with calculation from created_at - merged_at.

twpol added a commit to twpol/github-datasource that referenced this issue Apr 23, 2022
@twpol
Correctly calculate how long a merged PR was open for
a33ebb9 
Fixes grafana#145
@twpol twpol mentioned this issue Apr 23, 2022
Merged
bossinc pushed a commit that referenced this issue Jun 13, 2022
@twpol
Correctly calculate how long a merged PR was open for (#164)
a1d5900 
* Correctly calculate how long a merged PR was open for

Fixes #145

* test: Fix tests so PRs are closed/merged after being created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly calculate how long a merged PR was open for twpol/github-datasource
2 participants
@zakuru @timlevett