Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly calculate how long a merged PR was open for #164

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

twpol
Copy link
Contributor

@twpol twpol commented Apr 23, 2022

I believe this fixes #145 by calculating open_time on merged PRs as merged_at - created_at, which makes a lot more sense than the 0s/1s it currently contains :)

@zoltanbedi zoltanbedi self-requested a review May 5, 2022 07:44
@zoltanbedi zoltanbedi requested a review from bossinc June 8, 2022 09:52
Copy link
Contributor

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this!

@bossinc bossinc merged commit a1d5900 into grafana:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the open time field supposed to show ?
2 participants