Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README about support for template variables #68

Closed
vschettino opened this issue Sep 15, 2020 · 1 comment · Fixed by #69
Closed

Update README about support for template variables #68

vschettino opened this issue Sep 15, 2020 · 1 comment · Fixed by #69
Labels
type/docs Improvements or additions to documentation

Comments

@vschettino
Copy link
Contributor

As the README says:

We have aggressive caching enabled due to GitHub's rate limiting policies. When selecting a time range like "Last hour", a combination of the queries for each panel and the time range is cached temporarily.

  • I am trying to use a template variable in the "Query" field and it's not working

Template variables are currently not supported outside of the "Owner / Organization" and "Repository" fields.

I see it's done (#14, #29), but I feel like the FAQ on the README is outdated. I just tested and it works fine having a "milestone" variable addressed on Query field, as the prints show:

Captura de tela de 2020-09-15 14-11-58

Captura de tela de 2020-09-15 14-10-38

Captura de tela de 2020-09-15 14-01-00

If you guys think this is a good idea, I can open a PR. We could just remove this FAQ item and add extra info about the support in the "variables" section.

@kminehart
Copy link
Contributor

kminehart commented Sep 15, 2020

Yeah good call. This was fixed in this PR: #42.

I still want to clean up the way variables are handled (#43) but it definitely works now :D

@kminehart kminehart added type/docs Improvements or additions to documentation good first issue labels Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants