Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor variable replacement #43

Open
kminehart opened this issue Sep 10, 2020 · 0 comments
Open

Refactor variable replacement #43

kminehart opened this issue Sep 10, 2020 · 0 comments
Labels
type/chore Chores, code refactoring or maintenance work

Comments

@kminehart
Copy link
Contributor

At the moment we have an Indexable interface that each query option type extends that allows them to be indexed by string, which is then used with Object.keys(...) to replace all variables in string values.

This isn't ideal since it's complex and there are more type-safe solutions out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Chores, code refactoring or maintenance work
Projects
Status: Backlog
Development

No branches or pull requests

2 participants