Support querying multiple repos at a time via query variables

[jsheffield-roblox]

Problem

I would like to get metrics on multiple repos at a time. Technically, this is possible at the moment, just not with query variables.

I.E. Given the repos:

• Org/repo_a
• Org/repo_a

I can put the following in the query box repo:Org/repo_a repo:Org/repo_b

This works. However, the issue becomes when trying to use query variables to accomplish this.

Using this variable like so:

Just results in the query string being repo:{Org/repo_a,Org/repo_b}

I was unable to find any way to transform this string into what I need using the builtin grafana interpolation, as it seems to only support either plugin defined formats or a list of predefined formats here

Proposed solution

I believe this could be accomplished by simply splitting on commas in the repository field, then separating each of those into their own repo:x field in the query here, but I'm not sure if this is the best/desired way of accomplishing this.

So the final result would look something like this

where $repo_name is: Org/repo_a,Org/repo_b etc, then the generated query is repo:Org/repo_a repo:Org/repo_b

I'd be happy to create a pr to this effect, just want to make sure this is the "grafana" way of doing things and I'm not missing a better solution here!

[kminehart]

This is probably related to this:

#43

Basically we have to refactor the replaceVariables function to support these kinds of operations.

https://github.com/grafana/github-datasource/blob/master/src/DataSource.ts#L29

There are some default formatting options you can try, though I am not sure that they will work.
https://grafana.com/docs/grafana/latest/variables/advanced-variable-format-options/

Maybe try the CSV option? ${variable:csv}

[jsheffield-roblox]

Hm, I'm not sure I'm communicating the problem correctly (or perhaps I just don't understand what you're saying!)

Basically, the variable replacement does work, it just doesn't substitute it as anything meaningful for repos.

Github's api seems to only support repo:org/repo_a repo:org/repo_b repo:org/repo_c as syntax for including multiple repos. The plugin currently only offers the ability to do repo:org/repo_a,org/repo_b,org/repo_c (this is the csv format method).

My suggestion is splitting on the csv's commas in the code go code here, and turning those comma separated values into the format that github expects, repo:org/repo_a repo:org/repo_b repo:org/repo_c

[jsheffield-roblox]

@kminehart would you be willing to accept a pr to this effect? For the metrics we plan on collating with this plugin, we need support for multiple repos.

[kminehart]

Absolutely!

Sorry I haven't quite gotten to a lot of the issues on here yet. This plugin is part of our work on the Enterprise Plugins team and we support a lot of datasources. :D

To point you in the right direction, this should involve some changes in this function:

https://github.com/grafana/github-datasource/blob/master/src/DataSource.ts#L29

[marcoaaguiar]

@jsheffield-roblox did you ever manage to make any implementation to solve this issue?