Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for multi value variable queries #162

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

yesoreyeram
Copy link
Contributor

@yesoreyeram yesoreyeram commented Apr 21, 2022

This PR provides support for #90, #112, #113 via $__multiVar() macro in query fields.

Screen.Recording.2022-04-21.at.11.27.55.pm.mov

@yesoreyeram yesoreyeram marked this pull request as ready for review April 21, 2022 22:32
Copy link
Contributor

@scottlepp scottlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some minor suggestions

src/variables.ts Show resolved Hide resolved
pkg/github/macros.go Outdated Show resolved Hide resolved
@yesoreyeram yesoreyeram merged commit 5aeba2e into main Apr 26, 2022
@yesoreyeram yesoreyeram deleted the feature/multi-value-variable-query branch April 26, 2022 13:13
@CodyGirl
Copy link

Hi @yesoreyeram , Does this feature also work with github enterprise URL? What should be passed as prefix.. in your example video clip it is 'repo' but I'm confused if it is just a placeholder or is it the variable 'repo' you've on the dashboard?
For my use case the variable name is $repositories... should I call the query as $__multiVar(repo,$repositories) (Tried with github enterprise but didn't work)?

@yesoreyeram
Copy link
Contributor Author

@CodyGirl - See if the example in the docs helps. yes $__multiVar(repo,$repositories) is the correct syntax for filtering multiple repositories where your multi-value variable name is repositories.

@CodyGirl
Copy link

CodyGirl commented Jun 27, 2023

Thank you for your quick response. However, it is not working for me, here is a screenshot for the same:
image

I used Query inspector to see the query and the goes something like this: $__multiVar(repo,repo1,repo2...). Please help me if I'm doing something wrong.

@CodyGirl
Copy link

CodyGirl commented Jun 29, 2023

@yesoreyeram Any comments on this? It'll really be helpful to have your inputs.

@yesoreyeram
Copy link
Contributor Author

Hi @CodyGirl - Sorry for the delay. See this example helps.

variable setup

image

query

image

Does your repo variable contains owner name? It seems the without owner name in the repo variable this doesn't seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants